Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import sorting is disabled by flake8 noqa directive after switching to ruff linter #6942

Closed
albertvillanova opened this issue Jun 2, 2024 · 0 comments · Fixed by #6946
Closed

Import sorting is disabled by flake8 noqa directive after switching to ruff linter #6942

albertvillanova opened this issue Jun 2, 2024 · 0 comments · Fixed by #6946
Assignees
@albertvillanova
Labels
maintenance Maintenance tasks

Comments

@albertvillanova
Copy link
Member

When we switched to ruff linter in PR:

import sorting was disabled in all files containing the # flake8: noqa directive

We should re-enable import sorting on those files.
@albertvillanova albertvillanova added the maintenance Maintenance tasks label Jun 2, 2024
@albertvillanova albertvillanova self-assigned this Jun 2, 2024
@albertvillanova albertvillanova changed the title Import sorting is diabled by flake8 noqa directive after switching to ruff linter Import sorting is disabled by flake8 noqa directive after switching to ruff linter Jun 2, 2024
@albertvillanova albertvillanova mentioned this issue Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertvillanova albertvillanova

Labels
maintenance Maintenance tasks
Projects
None yet
Milestone
No milestone
1 participant
@albertvillanova