Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dreambooth Prior Preservation Loss Example #811

Closed
ghpkishore opened this issue Oct 12, 2022 · 4 comments
Closed

Dreambooth Prior Preservation Loss Example #811

ghpkishore opened this issue Oct 12, 2022 · 4 comments
Labels
stale Issues that haven't received updates

Comments

@ghpkishore
Copy link

What API design would you like to have changed or added to the library? Why?
What happens when a not safe for work image is generated by Stable Diffusion when I am trying to use it to create class images? It returns a black image. I want to know how does this Image affect the training process. Are the black images used for training purposes or are they discarded?
What use case would this enable or better enable? Can you give us a code example?
If a NSFW image is generated by SD during Dreambooth training, auto discard the image and generate more images to ensure that the total number of images are kept constant. I would not want to see "Potential NSFW content was detected in one or more images. A black image will be returned instead. Try again with a different prompt and/or seed." when I am 94% in generating class images.

Also, I do not see why safety feature needs to be active for dreambooth. Shouldn't safety feature be default OFF?

@patrickvonplaten
Copy link
Contributor

Hey @ghpkishore,

Regarding whether it should be turned off or on there was a longer discussion here #254 (comment)

In general, we never use the safety checker for training, but we might very well use it for evaluation (when evaluating the model in between training epochs).

Does this make sense?

Also cc @patil-suraj in case you have more/better information :-)

@ghpkishore
Copy link
Author

ghpkishore commented Oct 14, 2022

I get your point on not using the safety checker for training, but generation of images is part of the training process in dreambooth. So is this ( the safety checker being active) a bug in the code right now? Will read on the mentioned issue as well.

@patil-suraj
Copy link
Contributor

patil-suraj commented Oct 20, 2022

As Patrick said, it's not necessary to use safety checker during training for generating prior images.
This is now fixed in #922

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

3 participants