Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why different dimensionality state tensor with n_obs_steps vs not? #623

Open
genemerewether opened this issue Jan 8, 2025 · 1 comment

Comments

@genemerewether
Copy link

Curious about a design decision - why not have ACT with a [batch, n_obs_steps, state_dim] tensor but assert that n_obs_steps is length 1? Instead of [batch, state_dim]

Currently, we have to detect different dimensionality and handle when we're writing policy-agnostic code

@genemerewether
Copy link
Author

E.g. #194 - just adding the delta_timestamps changed the state dimension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant