Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor improvement] make it clear that data paths cannot contain whitespaces in dataset video encoding #632

Open
tlpss opened this issue Jan 13, 2025 · 0 comments

Comments

@tlpss
Copy link
Contributor

tlpss commented Jan 13, 2025

The video encoding in the dataset uses ffmpeg through a subprocess call.

This imposes a constraint on the file paths: they cannot contain a space as this is considered a separator by the CLI parser.

This currently fails silently. I believe we can make the framework easier to use by either:

  • epxlicitly checking and raising an Error if the paths contain whitespaces
  • encapsulating the paths with quotes to deal with the issue

best solution might depend on the assumptions made throughout the framework about path naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant