Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ONNX export for VisionDecoderEncoderModel #14812

Closed
lewtun opened this issue Dec 17, 2021 · 13 comments · Fixed by #19254
Closed

Enable ONNX export for VisionDecoderEncoderModel #14812

lewtun opened this issue Dec 17, 2021 · 13 comments · Fixed by #19254
Assignees

Comments

@lewtun
Copy link
Member

lewtun commented Dec 17, 2021

🚀 Feature request

As discussed on the forums, it would be nice if one could export VisionDecoderEncoderModel classes using the transformers.onnx package.

Motivation

It is currently not possible to export VisionDecoderEncoderModel classes (or vision models more generally), unless the end user is willing to write their own OnnxConfig. It might make sense to first explore what is involved in exporting ViT before tackling this more complex example.

Looking at this a bit more closely, I can see that transformers.onnx currently has a tight integration with tokenizers (e.g. to generate dummy inputs), so some refactoring will be necessary to support other modalities.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@lewtun lewtun reopened this Jan 24, 2022
@github-actions github-actions bot closed this as completed Feb 2, 2022
@albertoandreottiATgmail

I believe progress on this ticket will be welcome by the communitiy.

@lewtun
Copy link
Member Author

lewtun commented Mar 10, 2022

Hey @albertoandreottiATgmail thanks for the interest! This is next up on my list now that we've just merged the ViT export in #15658 :)

@IlyasMoutawwakil
Copy link
Member

Hey @albertoandreottiATgmail thanks for the interest! This is next up on my list now that we've just merged the ViT export in #15658 :)

Hi @lewtun is there any way (or script) to export trocr to onnx ?

@tanmayjain98
Copy link

Hi all, any updates on this? I've also tried to convert TrOCR to ONNX without success. Thanks in advance :) cc @lewtun

@NielsRogge
Copy link
Contributor

Re-opening this issue as it hasn't been resolved yet

@NielsRogge NielsRogge reopened this Aug 24, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@NielsRogge
Copy link
Contributor

Adding another feature request for this: NielsRogge/Transformers-Tutorials#183

@BakingBrains
Copy link
Contributor

Adding another feature request for this: NielsRogge/Transformers-Tutorials#183

Any updates on this one?

Thank you

@lewtun
Copy link
Member Author

lewtun commented Sep 23, 2022

Hi folks, @mht-sharma will be tackling this issue - stay tuned :)

@mht-sharma mht-sharma self-assigned this Sep 23, 2022
@BakingBrains
Copy link
Contributor

@mht-sharma Any updates?

Thank you.

@lewtun
Copy link
Member Author

lewtun commented Oct 4, 2022

@BakingBrains you can see the PR from @mht-sharma linked above - we should be able to get this merged pretty soon!

@BakingBrains
Copy link
Contributor

@lewtun and @mht-sharma Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants