Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance HfArgumentParser with Dict command-line parser #30204

Closed
xu-song opened this issue Apr 12, 2024 · 1 comment · Fixed by #30227
Closed

Enhance HfArgumentParser with Dict command-line parser #30204

xu-song opened this issue Apr 12, 2024 · 1 comment · Fixed by #30227
Assignees
Labels
Feature request Request for a new feature trainer

Comments

@xu-song
Copy link
Contributor

xu-song commented Apr 12, 2024

Feature request

Enhance HfArgumentParser with Dict command-line parser

Motivation

There are many arguments with dict typing, such as lr_scheduler_kwargs, gradient_checkpointing_kwargs.

lr_scheduler_kwargs: Optional[Dict] = field(

gradient_checkpointing_kwargs: Optional[dict] = field(

It is possible to pass dict arguments through json_file or yaml_file.
But it does not work in command-line.

Your contribution

TBD

@amyeroberts amyeroberts added trainer Feature request Request for a new feature labels Apr 12, 2024
@amyeroberts
Copy link
Collaborator

cc @pacman100 @muellerzr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature trainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants