Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better organization of many in-nodes #38

Closed
elamhut opened this issue May 22, 2021 · 7 comments
Closed

Better organization of many in-nodes #38

elamhut opened this issue May 22, 2021 · 7 comments
Assignees
Labels
feature New feature or request pending Pending approval ready Issue is fixed and ready to be deployed
Milestone

Comments

@elamhut
Copy link

elamhut commented May 22, 2021

After using the plugin for quite a while now I gotta say that I love it and I've been recommending to everyone that wants a more organized blueprint. The text below is my only issue with the plugin and something that really really bothers me and I hope you can solve it :)

Would it be possible to have a better treatment of in-nodes? Currently it's common to have a situation that looks like this:

UE4Editor_Jb4T8Q8TNN

But when you drag the node a bit further we can have a MUCH cleaner look like this:

UE4Editor_sR3gVcL31t

Even tho the second effect could be achieved in the first image the plugin currently doesn't do a very good job at untangling these situations. And in those cases we could end up with very unnecessary space between our nodes just to have a cleaner look.

@elamhut elamhut added feature New feature or request pending Pending approval labels May 22, 2021
@hugoattal
Copy link
Owner

@elamhut Thank you very much for the kind words 🙂 !

Hum, have you try the "Ribbon" feature?
image

It's available under "Edit/Editor Preferences/Electronic Nodes".

@hugoattal
Copy link
Owner

Quick before/after to illustrate:
image
image

@hugoattal hugoattal removed the pending Pending approval label May 22, 2021
@elamhut
Copy link
Author

elamhut commented May 22, 2021

Yes but the problem with ribbons is that the more you try to increase the offset the more they get inside the node. If there was another control to push them out it would be better. Because the way the ribbon works still clumps the wires too much.

MoiZe9At22

@hugoattal
Copy link
Owner

Hum, you could increase the "Horizontal Offset", but that would affect every wires 😕...
You could also set the "Wire Alignment" to left, but once a gain, it's not solving the core problem.

The fact that it sometimes pushes the wires inside the nodes is actually one of the reason I added the "experimental" to Ribbon Style. The thing is that wires are actually drawn one by one in a random order and I can't do much about it.

I actually might have an idea to force the push outside the nodes though, would that work for you?
Also, do you have in mind a perfect solution for the general problem, regardless of if it's possible or not?

@elamhut
Copy link
Author

elamhut commented May 22, 2021

I'd try a force push outside for sure.

I would think of doing something like this. I don't know if you can detect when this much overlap occurs, neither how much control you have over those curves, but when you detect a 90o angle going inside a node you could always force that node to have a Straight line then a 45o angle in the direction of the connection.

Photoshop_27B9NUVu5l

Then you can increase the straight line connecting the node with an offset.
For instance imagine that the image above has:
Target (blue) would have a straight line going into the node of size 1+0
Start Pos line is 1+1
Start Tangent 1+2
etc... So each straight line is slightly longer.

@hugoattal
Copy link
Owner

Hum, I see what you mean, I'll try to do that and keep you posted on 🤔

@hugoattal hugoattal self-assigned this May 24, 2021
@hugoattal
Copy link
Owner

@elamhut Done, it will be available in the next update!

Without ribbon
image

With ribbon
image

With ribbon and push outside
image

@hugoattal hugoattal added the ready Issue is fixed and ready to be deployed label Jun 13, 2021
@hugoattal hugoattal added this to the 3.3 milestone Jun 13, 2021
@hugoattal hugoattal added the pending Pending approval label Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request pending Pending approval ready Issue is fixed and ready to be deployed
Projects
None yet
Development

No branches or pull requests

2 participants