Balance refactor #3069
Open
Balance refactor #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Dzeranov
reviewed
Feb 7, 2025
packages/apps/job-launcher/server/src/database/migrations/1738321689843-addTokenToJob.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/job/job.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/job/job.interface.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/payment/payment.service.ts
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/payment/payment.service.ts
Outdated
Show resolved
Hide resolved
| } | ||
| paymentEntity.amount = -totalPaymentAmount; // In the currency used for the payment. | ||
| paymentEntity.currency = dto.paymentCurrency; | ||
| paymentEntity.rate = paymentCurrencyRate; |
There was a problem hiding this comment.
I believe it makes more sense to store an actual rate conversion (for example usd -> hmt (escrow fund token))
There was a problem hiding this comment.
It can be obtained anyway, using payments and job info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Closes #2982
Context behind the change
How has this been tested?
Unit tests partially updated. Job service needs a refactor so tests for this service will be implemented from scratch.
Release plan
Includes a migration to add
tokento jobs tablePotential risks; What to monitor; Rollback plan
Monitor payments table
Rollback: undo last migration