Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Job Launcher] Invalid event types for webhooks #3059

Open
dnechay opened this issue Jan 30, 2025 · 3 comments
Open

[Job Launcher] Invalid event types for webhooks #3059

dnechay opened this issue Jan 30, 2025 · 3 comments
Assignees

Comments

@dnechay
Copy link
Contributor

dnechay commented Jan 30, 2025

Describe the bug
Right now JL has next event types enum to validate webhook requests:

enum EventType {
  ESCROW_CREATED = 'escrow_created',
  ESCROW_CANCELED = 'escrow_canceled',
  ESCROW_COMPLETED = 'escrow_completed',
  TASK_CREATION_FAILED = 'task_creation_failed',
  ESCROW_FAILED = 'escrow_failed',
  ABUSE_DETECTED = 'abuse_detected',
}

Processing on JL is supported for next event types:

  • EventType.ESCROW_COMPLETED
  • EventType.TASK_CREATION_FAILED
  • EventType.ESCROW_FAILED

However, what we have in other oracles is a bit different:

  • escrow_completed is sent from Reputation Oracle to JL and all good here
  • task_creation_failed is sent from Fortune ExcO, but CVAT ExcO sends job_creation_failed
  • escrow_failed is not sent in system at all
  • escrow_cleaned is sent from CVAT ExcO, but not handled in JL

Expected behavior
Webhook event types should be aligned within the system

@flopez7
Copy link
Contributor

flopez7 commented Feb 7, 2025

We’ve decided to keep escrow_completed as is. Once @Dzeranov confirms, task_creation_failed will be removed in favor of the standard escrow_failed event for any errors. Additionally, escrow_cleaned will be removed from the CVAT Exchange Oracle to ensure consistent event types across the system

@Dzeranov
Copy link
Contributor

Dzeranov commented Feb 7, 2025

escrow_cleaned is sent from CVAT ExcO, but not handled in JL

Exchange Oracle sends escrow_cleaned only to Recording Oracle so no further actions required.

@Dzeranov
Copy link
Contributor

Dzeranov commented Feb 7, 2025

task_creation_failed is sent from Fortune ExcO, but CVAT ExcO sends job_creation_failed

We should get rid of task_creation_failed on both JL and Fortune oracles and use escrow_failed instead.
CVAT Exchange Oracle will use it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants