Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

chore: fix caching of ignored files #111

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore: fix caching of ignored files #111

merged 1 commit into from
Oct 19, 2023

Conversation

mdjermanovic
Copy link
Contributor

Fixes getConfig() caching for ignored files.

Configs for ignored files are stored as undefined in the cache, so if (finalConfig) was treating them as cache misses.

@nzakas
Copy link
Contributor

nzakas commented Oct 16, 2023

Can you add a test for this?

nzakas
nzakas approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see that we basically can't create a test because the return value is the same, it's just the amount of time it takes to get there.

@nzakas nzakas merged commit 839d838 into humanwhocodes:main Oct 19, 2023
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdjermanovic @nzakas