This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
fix: Config with just ignores should not always be applied #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a config has `ignores` and not `files`, plus at least one other key, it should match all files that don't match `ignores` and the other keys should be merged into the resulting config. Prior to this, such a config was always merged in regardless if the filename matched `ignores`; after this change, it correctly merges in only when `ignores` matches. Refs eslint/eslint#17103
nzakas
changed the title
|
Okay, I think I got this straightened out now. |
mdjermanovic
approved these changes
May 12, 2023
Co-authored-by: Milos Djermanovic <[email protected]>
|
Ah thanks. I added the test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a config has
ignoresand notfiles, plus at least one other key, it should match all files that don't matchignoresand the other keys should be merged into the resulting config only if the filename matches a files pattern in another config.Prior to this, such a config was always merged in regardless if the filename matched
ignores; after this change, it correctly merges in only whenignoresmatches.Refs eslint/eslint#17103
cc @mdjermanovic