Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import CSV 2.0 #2310

Closed
6 of 8 tasks
txau opened this issue Apr 10, 2019 · 13 comments · Fixed by #2340, #2347 or #2424
Closed
6 of 8 tasks

Import CSV 2.0 #2310

txau opened this issue Apr 10, 2019 · 13 comments · Fixed by #2340, #2347 or #2424

Comments

@txau
Copy link
Collaborator

txau commented Apr 10, 2019

  • Add an icon in uploads for importing CSV file
  • Halt on first error and provides feedback
  • Add support for multiple languages (add id and lang columns)
  • Support updates when Uwazi ids are provided
  • Support file uploads (upload a zip)
  • validate zip has only one csv
  • When I don't have a lang, I use the default lang to create the records
  • Add an icon for importing thesauri in a thesauri
@RafaPolit
Copy link
Member

RafaPolit commented May 15, 2019

  • Be able to delete file once assigned (removing the column has no effect, assigning empty value to the column has no effect either) (We will decide how to approach this if the need arises... it needs to be discussed with partial updates of metadata, CSV export, and other related functionality)

@RafaPolit
Copy link
Member

RafaPolit commented May 20, 2019

The UI, we have some general UX questions that we have included in #2353, or maybe everything should be consolidated here?

@daneryl
Copy link
Collaborator

daneryl commented Jul 11, 2019

@RafaPolit @txau

The UI, we have some general UX questions that we have included in #2353, or maybe everything should be consolidated here?

lets finish the the more tech side here and continue with ux things in the other one.

Be able to delete file once assigned (removing the column has no effect, assigning empty value to the column has no effect either)

should a blank value on the file column delete the file then ?

@daneryl
Copy link
Collaborator

daneryl commented Jul 11, 2019

@txau thinking about this

validate zip has only one csv

what if they want to add a csv as an attachment, should we some kind of naming convention to specify which csv to use for the import ?

@txau
Copy link
Collaborator Author

txau commented Jul 12, 2019

@daneryl good call. It totally makes sense.

@daneryl
Copy link
Collaborator

daneryl commented Jul 12, 2019

@txau, so do nothing about it until we implement attachments sounds good ?

@txau
Copy link
Collaborator Author

txau commented Jul 12, 2019

@daneryl since you are going to check nevertheless for the presence of a CSV, check for a particular CSV name, ie. import.csv.

@habbes
Copy link
Contributor

habbes commented Jul 18, 2019

@daneryl when you have a .zip file with multiple files, including multiple .csv files, it correctly imports the import.csv file.

If there's no import.csv in the zip folder, this notifcation is displayed:
Screenshot 2019-07-18 at 14 42 32

It stays on the sidebar indefinitely. You can close it, but it reappears when you click the "import" button. Which means you lose access to the import form, until you refresh the page.

The notification goes on the top bar when you go to the library page:
Screenshot 2019-07-18 at 14 46 19

I can't see any way to close it. It stays there indefinitely, until you refresh the page.

@daneryl
Copy link
Collaborator

daneryl commented Jul 18, 2019

@habbes ok, nice one ... will look into it thx !

@daneryl
Copy link
Collaborator

daneryl commented Jul 19, 2019

@habbes the fix is ready on the PR, error handling was missing on the endpoint, ready for QA

@habbes
Copy link
Contributor

habbes commented Jul 19, 2019

@daneryl alright

And regarding this:

what if they want to add a csv as an attachment, should we some kind of naming convention to specify which csv to use for the import ?

How do I add attachments in the zip for imports?

@daneryl
Copy link
Collaborator

daneryl commented Jul 19, 2019

@habbes attachments support is not implemented yet, this was just to prevent this problem in the future.

@habbes
Copy link
Contributor

habbes commented Jul 19, 2019

@daneryl oh alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment