Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unique 'seller_key' when user pushes an offer to the Marketplace #419

Open
zAnonKekz opened this issue Aug 8, 2023 · 6 comments
Open
Assignees
Labels
ZIP(Zano Improvement Proposal) Some proposition, that may be discussed

Comments

@zAnonKekz
Copy link

In order for a buyer to ensure an offer is actually from the correct seller, the seller should be able to publicly show their 'seller key' on their socials, this unique seller key should also then be present as one of the json parameters returned on each offer when fetching them from the marketplace.

The 'seller key' ofcourse should be unique and connected to the originating wallet, which will help ensure buyers are not scammed by sellers imitating other sellers, and also help devs filter the offers into the correct 'marketplace' from which they originate! this is essential for a properly functioning marketplace and to be able to sort offers and group them to their respective 'store'.

@cryptozoidberg
Copy link
Member

@kekzploit thanks for the valuable proposal, we'll work on it as soon as we finish with delivering main net for Zarcanum, hope it's not tool late, so far i would suggest as workaround use one of the fields ("cnt" for example) and keep there alias, of course it's not validated, but at least to build some codebase around. When we get to this point we'll add field that will hold alias and be validated that it actually belong to it.

@zAnonKekz
Copy link
Author

For further clarification, each wallet has a unique "vendor_key" which is cryptographically unique and derived from the wallet. This key should then be visible within the json response of the offers created by that wallet; for example:

{
  "id": 0,
  "jsonrpc": "2.0",
  "result": {
    "offers": [
      {
        ...
        "vendor_key": "3hg56uyk2g456k35g62h4il56uh2i35yugyi53g62iu53hb..etc"
      }
    ],
    "status": "",
    "total_offers": 0
  }
}

@zAnonKekz
Copy link
Author

yes, the alias is good!

@sowle sowle added the ZIP(Zano Improvement Proposal) Some proposition, that may be discussed label Aug 10, 2023
@zAnonKekz
Copy link
Author

I thought, there should still be something unique returned in the event a user doesnt have an alias!

@cryptozoidberg cryptozoidberg self-assigned this Jun 27, 2024
@kekzploit
Copy link

@cryptozoidberg @sowle Did we make any progress with this?

@cryptozoidberg
Copy link
Member

@cryptozoidberg @sowle Did we make any progress with this?

oh, totally forgot about it, sorry. @sowle could you please take it and put somewhere to your backlog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZIP(Zano Improvement Proposal) Some proposition, that may be discussed
Projects
None yet
Development

No branches or pull requests

4 participants