From e48519a1e2f94eb7fa3fe929a1b34cd426892555 Mon Sep 17 00:00:00 2001 From: Sean McArthur Date: Wed, 13 Oct 2021 17:05:34 -0700 Subject: [PATCH] refactor(http1): adjust a few tracing event outputs --- src/proto/h1/io.rs | 1 + src/proto/h1/role.rs | 13 ++----------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/proto/h1/io.rs b/src/proto/h1/io.rs index a7523001bc..9fa6899001 100644 --- a/src/proto/h1/io.rs +++ b/src/proto/h1/io.rs @@ -223,6 +223,7 @@ where match Pin::new(&mut self.io).poll_read(cx, &mut buf) { Poll::Ready(Ok(_)) => { let n = buf.filled().len(); + trace!("received {} bytes", n); unsafe { // Safety: we just read that many bytes into the // uninitialized part of the buffer, so this is okay. diff --git a/src/proto/h1/role.rs b/src/proto/h1/role.rs index 81cb86e846..5c701ed429 100644 --- a/src/proto/h1/role.rs +++ b/src/proto/h1/role.rs @@ -120,11 +120,7 @@ impl Http1Transaction for Server { /* SAFETY: it is safe to go from MaybeUninit array to array of MaybeUninit */ let mut headers: [MaybeUninit>; MAX_HEADERS] = unsafe { MaybeUninit::uninit().assume_init() }; - trace!( - "Request.parse([Header; {}], [u8; {}])", - headers.len(), - buf.len() - ); + trace!(bytes = buf.len(), "Request.parse"); let mut req = httparse::Request::new(&mut []); let bytes = buf.as_ref(); match req.parse_with_uninit_headers(bytes, &mut headers) { @@ -144,7 +140,6 @@ impl Http1Transaction for Server { is_http_11 = false; Version::HTTP_10 }; - trace!("headers: {:?}", &req.headers); record_header_indices(bytes, &req.headers, &mut headers_indices)?; headers_len = req.headers.len(); @@ -879,11 +874,7 @@ impl Http1Transaction for Client { // SAFETY: We can go safely from MaybeUninit array to array of MaybeUninit let mut headers: [MaybeUninit>; MAX_HEADERS] = unsafe { MaybeUninit::uninit().assume_init() }; - trace!( - "Response.parse([Header; {}], [u8; {}])", - headers.len(), - buf.len() - ); + trace!(bytes = buf.len(), "Response.parse"); let mut res = httparse::Response::new(&mut []); let bytes = buf.as_ref(); match ctx.h1_parser_config.parse_response_with_uninit_headers(