Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two identical Service traits #1460

Closed
DustinByfuglien opened this issue Mar 10, 2018 · 4 comments
Closed

Two identical Service traits #1460

DustinByfuglien opened this issue Mar 10, 2018 · 4 comments
Labels
C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@DustinByfuglien
Copy link

DustinByfuglien commented Mar 10, 2018 •
edited
Loading

Why there are two Service traits: hyper::client::Service and hyper::server::Service?
As I believe a Service trait need not depend from client or server nature of things.

May be use hyper::Service instead? Or only hyper::server::Service?
@seanmonstar
Copy link
Member

Yea, they don't really need to be as different exports. I suppose I was thinking you'd do use hyper::client::{Client, Request, Service} and what-not... Could be cleaned up.

@DustinByfuglien
Copy link
Author

DustinByfuglien commented Mar 13, 2018 •
edited
Loading

Ops.. I'm accidentally close a issue.

I agree. Two exports of one thing brings some discourage.

@seanmonstar
Copy link
Member

This should be handled with #1461, likely just export hyper::Service.

@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. labels Mar 19, 2018
@DustinByfuglien
Copy link
Author

Thanx.
hyper::Service sounds reasonably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @DustinByfuglien