Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http2): configure HTTP/2 frame size in the high-level builders too #2214

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

goffrie
Copy link
Contributor

@goffrie goffrie commented Jun 2, 2020

Oops, I missed this in #2211.

/// Passing `None` will do nothing.
///
/// If not set, hyper will use a default.
pub fn http2_max_frame_size(&mut self, sz: impl Into<Option<u32>>) -> &mut Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builder uses by-value style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

@goffrie goffrie force-pushed the frame-size-again branch from 915f5cf to 5655b0c Compare June 3, 2020 00:50
@seanmonstar seanmonstar merged commit 2354a7e into hyperium:master Jun 3, 2020
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this pull request Jul 26, 2021
@goffrie goffrie deleted the frame-size-again branch October 26, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants