Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport): Add server side peer cert support #228

Merged
merged 2 commits into from
Jan 11, 2020
Merged

feat(transport): Add server side peer cert support #228

merged 2 commits into from
Jan 11, 2020

Conversation

LucioFranco
Copy link
Member

This finishes up #85

@LucioFranco LucioFranco requested a review from jen20 January 11, 2020 21:55
@LucioFranco LucioFranco mentioned this pull request Jan 11, 2020
Closed
@LucioFranco LucioFranco merged commit af807c3 into master Jan 11, 2020
@LucioFranco LucioFranco deleted the lucio/tls-client-identity branch January 11, 2020 22:17
@jen20
Copy link
Contributor

jen20 commented Jan 13, 2020

This looks good to me - I’d come to the conclusion that actual parsing of the certificate should be handled by an interceptor in the client also.

@LucioFranco
Copy link
Member Author

@jen20 right I suspect at that point a user can bring in what ever parsing they want, instead of us providing it.

@Ten0 Ten0 mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen20 jen20 Awaiting requested review from jen20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucioFranco @jen20