Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty 'google.protobuf.rs' file creation when using well-known types #314

Closed
evdokimovs opened this issue Mar 31, 2020 · 4 comments
Closed

Empty 'google.protobuf.rs' file creation when using well-known types #314

evdokimovs opened this issue Mar 31, 2020 · 4 comments

Comments

@evdokimovs
Copy link

Bug Report

Version

tonic-build v0.1.1

Platform

Linux DellArch 5.5.8-arch1-1 #1 SMP PREEMPT Fri, 06 Mar 2020 00:57:33 +0000 x86_64 GNU/Linux

Crates

tonic-build

Description

When Protobuf well-known types used in spec, tonic-build generates empty google.protobuf.rs file in the output directory.

Fields with well-known types can be normally used. The problem is only in empty file creation.

Repository with reproduction of this bug: evdokimovs/tonic-build-empty-file.
@LucioFranco
Copy link
Member

This sounds like it may be a prost bug, rather than a tonic one?

@SkamDart SkamDart mentioned this issue Apr 1, 2020
Closed
@evdokimovs
Copy link
Author

@LucioFranco ,

This sounds like it may be a prost bug, rather than a tonic one?

Yep, you're right, this is prost's bug. Here is the issue with this bug. But, as mentioned in the #317 and danburkert/prost#228 issues, compile_well_known_types usage can fix this.

@LucioFranco
Copy link
Member

@evdokimovs #318 just merged so this is now supported!

@evdokimovs
Copy link
Author

@LucioFranco ,

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucioFranco @evdokimovs