fix(transport): Apply tls-connector for discovery when applicable (#334) #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanot would you be able to rebase against master? That should get CI working again. |
johanot
force-pushed
the
v0.2.0-discovery-https
branch
from
4012814 to
396d4c2
Compare
|
Done :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying my luck with a PR for this, even though I'm a newbie here.
Please provide feedback and correct me if I'm wrong.
fixes #334
Solution
Apply optional tls-connector to the discovery client if the tls-feature is enabled.
Performed some tests combined with this patch: johanot/etcd-rs@ad8a264 on etcd-rs - since etcd-rs uses the balanced_list service endpoint to connect to etcd. It seemed to work just fine using TLS.