-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transport): Add content-type for Unimplemented #434
Conversation
Co-authored-by: Lucio Franco <[email protected]>
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Do we have any tests that cover this? I am compiling against the latest commit in master (40e64b5) and I'm getting a Here's a snippet of my Cargo.toml: tonic = { git = "https://github.com/hyperium/tonic/" } And the corresponding snippet from Cargo.lock:
|
@edrevo I don't see anything wrong with this PR but we don't have tests for this specific one. Do you by chance have an output of the h2 frames between that and grpc-go, it would be good to see what is actually happening on the wire. |
Is there any easy way of getting the actual frames? I've set the log level to trace, but the actual frame content doesn't seem to be logged: https://gist.github.com/edrevo/853fe19a3593cfd724fa779332310c0a |
Found it! #441 |
Motivation
According to the spec content-type should be set
Solution
Add the application/grpc for
Unimplemented