Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Tower integration is compatible with complex middleware #652

Closed
davidpdrsn opened this issue May 17, 2021 · 1 comment
Closed

Make sure Tower integration is compatible with complex middleware #652

davidpdrsn opened this issue May 17, 2021 · 1 comment
Assignees
@davidpdrsn
Milestone
0.5

Comments

@davidpdrsn
Copy link
Member

Reminder to self

Once #651 and #622 are both merged we should make sure all the pieces fit together when using more complex middleware. Converting the tonic example in tower-http to use tonic's Server rather than hyper's should be a good test.

I tried getting things working but the fact that BoxBody uses Status as the error type caused some issues since Server::add_service requires the response body type to be BoxBody.
@davidpdrsn davidpdrsn added this to the 0.5 milestone May 17, 2021
@davidpdrsn davidpdrsn self-assigned this May 17, 2021
@davidpdrsn
Copy link
Member Author

Fixed as part of #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidpdrsn davidpdrsn

Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@davidpdrsn