feat(transport): add connect timeout to Endpoint
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls in [hyper-timeout] which has a connector that can have a timeout applied. I did consider vendoring hyper-timeout since its a fairly small crate. I guess we can always do that later since its not exposed publicly. I would also like to add a test but I'm not sure about the best way of testing this. Fixes #498 [hyper-timeout]: https://github.com/hjr3/hyper-timeout
|
hmmm I'd rather vendor this personally, what do you think @davidpdrsn probably not worth an extra dependency etc |
LucioFranco
approved these changes
Jun 21, 2021
|
I will get some time later this week to focus on OSS. Will vendor hyper-timeout then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in hyper-timeout which has a connector that can have a timeout
applied. I did consider vendoring hyper-timeout since its a fairly small
crate. I guess we can always do that later since its not exposed
publicly.
I would also like to add a test but I'm not sure about the best way of
testing this.
Fixes #498