Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tonic-build invalid version number #987

Closed
Morgadoooo opened this issue Apr 28, 2022 · 4 comments · Fixed by #988
Closed

tonic-build invalid version number #987

Morgadoooo opened this issue Apr 28, 2022 · 4 comments · Fixed by #988

Comments

@Morgadoooo
Copy link

Bug Report

Invalid version number for tonic-build

Version

tonic v0.7.1 ()
tonic v0.7.1 ()
tonic-build v0.7.0 (*)

Description

After the release of tonic 0.7.1, it seems that you forgot to update the version of tonic-build that don't allow us to use the fix made in this PR [https://github.com//pull/974].
@LucioFranco LucioFranco mentioned this issue Apr 28, 2022
Merged
@LucioFranco
Copy link
Member

Oh good catch, I wish this stuff was a bit more automated not sure how I missed that. Will get a release out asap.

@davidpdrsn
Copy link
Member

I can probably write a little shell script for CI that checks the versions are always the same.

@LucioFranco
Copy link
Member

@davidpdrsn we could prob setup automatic releases?

@LucioFranco
Copy link
Member

@Morgadoooo 0.7.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Prepare tonic-build 0.7.1 hyperium/tonic
3 participants
@davidpdrsn @LucioFranco @Morgadoooo