Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merkle tree hook to agent config #2753

Closed
tkporter opened this issue Sep 27, 2023 · 2 comments
Closed

Add merkle tree hook to agent config #2753

tkporter opened this issue Sep 27, 2023 · 2 comments
Assignees
Labels

Comments

@tkporter
Copy link
Collaborator

Probably blocked on #2747 / associated work related to hook config / artifact / deploy management, where we'd like to generate the agent config based off the deployed hook address.

  • Atm, V3 agents get the merkle tree hook by querying the Mailbox's requiredHook. We can't always assume that the Mailbox's requiredHook will be the merkle tree hook -- at best, this will result in incorrect behavior causing an agent to crash, at worst, this feels like a security problem
  • Consider changing the config structure to be hooks.merkleTreeHook or something instead of just having merkleTreeHook alongside the mailbox, validator announce, etc. If we do this, then we should probably move the IGP in there too? Validator announce could be argued to be a hook too, but I don't feel strongly there tbh. I could see it also making sense to just keep merkleTreeHook alongside the mailbox though, just do whatever feels most natural & makes sense for the future
  • Should make sure e2e tests still pass -- i.e. deploy tooling that creates the agent config json should include the merkleTreeHook
@tkporter tkporter moved this to Next Sprint in Hyperlane Tasks Sep 27, 2023
@avious00 avious00 moved this from Next Sprint to Sprint in Hyperlane Tasks Sep 27, 2023
@tkporter
Copy link
Collaborator Author

2 days

@avious00 avious00 added the v3 label Sep 28, 2023
@avious00
Copy link
Contributor

agent portion of Kunal's merkle tree hook work

@avious00 avious00 moved this from Sprint to In Progress in Hyperlane Tasks Oct 4, 2023
@avious00 avious00 moved this from In Progress to In Review in Hyperlane Tasks Oct 4, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Hyperlane Tasks Oct 10, 2023
@yorhodes yorhodes assigned yorhodes and unassigned daniel-savu Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants