Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK abstractions should throw an error if chains in configuration are not covered by multiprovider #877

Closed
nambrot opened this issue Aug 3, 2022 · 1 comment
Labels

Comments

@nambrot
Copy link
Contributor

nambrot commented Aug 3, 2022

#394 was fixed by using the intersection between chains in the configuration and the chains of the multiprovider.

There is an argument that this will be surprising to developers. In a world in which one uses an app-independent multiprovider (like infra does), imo it would be surprising to get a subset of the chains in the configuration. Instead, the abstractions could throw an error and force the developer to adjust the configuration if the subset is desired

@nambrot nambrot added the dx label Aug 3, 2022
@asaj
Copy link
Contributor

asaj commented May 3, 2023

I believe we've done this

@asaj asaj closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants