chore: adding custom gitguardian check #2313
Merged
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzell22
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
takeutak
approved these changes
Mar 10, 2023
|
Gitguardian scan is not getting triggered when changed to pull_request_target from the original pull_request. Currently figuring out how to make the workflow triggered. |
ruzell22
force-pushed
the
customgitguardian
branch
from
3be69e8 to
ede5c6b
Compare
|
By default, the environmental secrets is not being accessed by this pull request because it is from a fork repository. However, I have tested it with an exposed test token in replacement with the secrets.GITGUARDIAN_API_KEY and the scanner worked successfully (screenshots are sent to @petermetz privately). After the PR is merged, it is expected to have access with the environmental secrets and the scanner will run successfully. The test codes used in testing were all deleted to prevent further usage of it. The PR for the clean up of #720 will be made after this PR is merged. |
petermetz
requested changes
Mar 29, 2023
There was a problem hiding this comment.
@ruzell22 Please change the following things:
- Squash the commits into a single one with an interactive git rebase
- Make sure to explain in the commit message body why this was necessary when we have a stock git guardian workflow action on the GitHub marketplace (because that one was not possible to be configured for exclusions if I remember correctly)
- Also clarify what was your solution to the problem you outlined in your comment above [1]
[1]:
Gitguardian scan is not getting triggered when changed to pull_request_target from the original pull_request. Currently figuring out how to make the workflow triggered.
ruzell22
force-pushed
the
customgitguardian
branch
from
ede5c6b to
e88ce7d
Compare
|
Hello @petermetz , commit is now squashed into one and the commit message is also changed. Thank you. |
ruzell22
requested review from
petermetz
and removed request for
VRamakrishna,
sandeepnRES and
izuru0
related to hyperledger-cacti#720 This includes gitguardian workflow + configuration file This change was necessary even if we have stock git guardian workflow action because it was not possible to be configured for exclusions. The scanner was not getting triggered by pull_request_target as expected to access the secrets environment variable so it was returned to the original pull_request. By default, secrets is not possible to be accessed by a pull request from a fork repository unless it is merged to the main repository. Hence, the original pull_request will work after merging. The test tokens used in testing were all deleted to prevent further usage of it. Signed-off-by: ruzell22 <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
customgitguardian
branch
from
e88ce7d to
bdd8372
Compare
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 7, 2023
…#2379 fixes: 2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 13, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 27, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 27, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 27, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Apr 27, 2023
…#2379 fixes: hyperledger-cacti#2379 related to: hyperledger-cacti#2313 and hyperledger-cacti#1996 This fixes the Invalid token header, no credentials provided error of the custom gitguardian workflow. Signed-off-by: ruzell22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #720
this includes gitguardian workflow + configuration file