Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation version of SATP #2748

Closed
wants to merge 74 commits into from

Conversation

outsidethecode
Copy link
Contributor

Pull Request Requirements
[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit
[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

outsidethecode and others added 30 commits June 29, 2023 15:24
@VRamakrishna
Copy link
Contributor

@outsidethecode Please write a short description of this feature in the PR's main comment. Add a link to the SATP Core draft for reference. List the modules impacted by this change (like Weaver relay, Weaver Fabric driver, sample chaincode, etc.)

@outsidethecode outsidethecode changed the title Satp First implementation version of SATP Dec 11, 2023
@outsidethecode
Copy link
Contributor Author

This is the first implementation of the SATP protocol. The objective is to augment the existing Weaver relay implementation to include the gateway functionality. The details of the draft version of SATP can be found here.

The main modules impacted by this implementation are:

  • Weaver Relay
  • Weaver Fabric driver
  • Sample chaincode called satpsimpleasset
  • The relevant protos

@petermetz
Copy link
Contributor

@petermetz for some context, this is the code from the SATP mentorship project. It is still not ready for a full review.

@RafaelAPB @outsidethecode Thank you, this is looking great at a first glance! I'll have a list of things once it's ready for review, but in the meantime just wanted to say that it is looking great and to please don't forget to include automated test cases with the PR :-)

@petermetz
Copy link
Contributor

petermetz commented Dec 11, 2023

@RafaelAPB @outsidethecode Also a quick git advice because I see you have some merge conflicts: It is exponentially easier to resolve merge conflicts if you squash all your work into a single commit first and then do a rebase onto upstream/main.
If you need help with it just let me know.

@@ -0,0 +1,708 @@
# This file is automatically @generated by Cargo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsidethecode This file probably crept in by mistake. Please delete it.

corrected the version of cacti_weaver_protos_rs and added the copyright statement

removed the code copied from fabric-cli
@VRamakrishna VRamakrishna mentioned this pull request Jan 9, 2024
5 tasks
@petermetz
Copy link
Contributor

@outsidethecode Just to double check: Are you still working on this particular PR?

@petermetz
Copy link
Contributor

Nvm I just saw your other PR.
Please do not open multiple PRs with the same content in the future (we ask this very politely in the contributing guide as well)

@petermetz petermetz closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants