-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First implementation version of SATP #2748
Conversation
feat: Sapt stage 1
…te the asset status
@outsidethecode Please write a short description of this feature in the PR's main comment. Add a link to the SATP Core draft for reference. List the modules impacted by this change (like Weaver relay, Weaver Fabric driver, sample chaincode, etc.) |
Signed-off-by: outsidethecode <[email protected]>
…on-receipt SATP steps 1.1, 1.2, 2.1A, 2.2, 2.3, and 2.4
Signed-off-by: outsidethecode <[email protected]>
Initial log functionality
feat: initial rfcs for satp
GitHub actions
This is the first implementation of the SATP protocol. The objective is to augment the existing Weaver relay implementation to include the gateway functionality. The details of the draft version of SATP can be found here. The main modules impacted by this implementation are:
|
@RafaelAPB @outsidethecode Thank you, this is looking great at a first glance! I'll have a list of things once it's ready for review, but in the meantime just wanted to say that it is looking great and to please don't forget to include automated test cases with the PR :-) |
@RafaelAPB @outsidethecode Also a quick git advice because I see you have some merge conflicts: It is exponentially easier to resolve merge conflicts if you squash all your work into a single commit first and then do a rebase onto |
@@ -0,0 +1,708 @@ | |||
# This file is automatically @generated by Cargo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outsidethecode This file probably crept in by mistake. Please delete it.
corrected the version of cacti_weaver_protos_rs and added the copyright statement removed the code copied from fabric-cli
corrected the version of cacti_weaver_protos_rs and added the copyright statement removed the code copied from fabric-cli
Signed-off-by: outsidethecode <[email protected]>
@outsidethecode Just to double check: Are you still working on this particular PR? |
Nvm I just saw your other PR. |
Pull Request Requirements
[ ] Rebased onto
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.[ ] Have git sign off at the end of commit message to avoid being marked red. You can add
-s
flag when usinggit commit
command. You may refer to this link for more information.[ ] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.