Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(satp-hermes): when a db is not provided it creates a local repository, remote db is not required anymore #3728

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(satp-hermes): when a db is not provided it creates a local repository, remote db is not required anymore #3728

merged 1 commit into from
Jan 22, 2025

Conversation

LordKubaya
Copy link
Contributor

  • Fixed logging issues.
  • If no configuration for the local database is provided, the system will default to using a local SQLite3 database and perform a migration upon the first login.

@LordKubaya
fix(satp-hermes): when a db is not provided it will create a reposito…
21dcfa0 
…ry, remote db is not required anymore

Signed-off-by: Carlos Amaro <[email protected]>
@LordKubaya LordKubaya mentioned this pull request Jan 21, 2025
Merged
RafaelAPB
RafaelAPB approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@RafaelAPB RafaelAPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A suggestion: "fix(satp-hermes): when a db is not provided it creates a local repository, remote db is not required anymore" should state the code changes, not why.
E.g., a more suitable title could be "fix(satp-hermes): make remoteRepository optional", with your description in the commit message

@RafaelAPB RafaelAPB merged commit 1387bb5 into hyperledger-cacti:satp-dev Jan 22, 2025
6 of 8 checks passed
@LordKubaya LordKubaya deleted the no-db-fix branch February 17, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelAPB RafaelAPB RafaelAPB approved these changes

@petermetz petermetz Awaiting requested review from petermetz petermetz is a code owner

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@jagpreetsinghsasan jagpreetsinghsasan Awaiting requested review from jagpreetsinghsasan jagpreetsinghsasan is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

@outSH outSH Awaiting requested review from outSH outSH is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordKubaya @RafaelAPB