Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(daml): add openapi-validation.test.ts #3765

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raynatopedrajeta
Copy link
Contributor

Primary Changes

  1. Add openapi-validation.test.ts on daml connector.
Fixes #3707 

**Pull Request Requirements**
- [ ] Rebased onto `upstream/main` branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
- [ ] Have git sign off at the end of commit message to avoid being marked red. You can add `-s` flag when using `git commit` command. You may refer to this [link](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) for more information.
- [ ] Follow the Commit Linting specification. You may refer to this [link](https://www.conventionalcommits.org/en/v1.0.0-beta.4/#specification) for more information. 

**Character Limit**
- [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

**A Must Read for Beginners**
For rebasing and squashing, here's a [must read guide](https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing) for beginners.

@raynatopedrajeta raynatopedrajeta marked this pull request as draft February 13, 2025 09:19
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3707 branch 2 times, most recently from b795287 to 3a04cd5 Compare February 13, 2025 12:36
@raynatopedrajeta raynatopedrajeta marked this pull request as ready for review February 13, 2025 12:54
@jagpreetsinghsasan
Copy link
Contributor

Please fix the failing checks @raynatopedrajeta

@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3707 branch 2 times, most recently from 0095890 to 2b7a28b Compare February 19, 2025 09:55
Primary Changes
----------------
1. Add openapi-validation.test.ts on daml connector.

Fixes hyperledger-cacti#3707

Signed-off-by: raynato.c.pedrajeta <[email protected]>
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3707 branch from 2b7a28b to a8a3ee8 Compare February 19, 2025 10:02
@raynatopedrajeta
Copy link
Contributor Author

Please fix the failing checks @raynatopedrajeta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants