Ethereum adapter has no tests

[benjamincburns]

Context

A recent PR broke the Ethereum adapter in a way that would have been very apparent if we had some tests guarding even its most basic functionality. The PR changed the web3 dependency to a much older version.

Expected Behavior

CI would have caught the mistake.

Actual Behavior

The change was merged, and the ethereum adapter was completely broken.

Possible Fix

An end-to-end test that runs a very minimal benchmark against the headless version of ganache. Ganache is a tool from Truffle, written in JavaScript, that emulates an ethereum network.

(Disclosure: I used to be the maintainer of Ganache).

Steps to Reproduce

1. Submit a PR that changes the web3 dependency of the caliper-ethereum module to 0.22.x.
2. Observe that CI checks do not fail.

Context

I work with the PegaSys team now, and my primary focus is on improving the performance of Hyperledger Besu. My benchmarking automation was relying on master, as there were other in-flight bug fixes that I needed. When the PR in question was merged, my benchmarking automation broke, and I needed to pin it to an earlier commit hash.

Your Environment

• Version used: master
• Environment name and version (e.g. Chrome 39, node.js 5.4): N/A
• Operating System and version (desktop or mobile): N/A
• Link to your project: https://github.com/hyperledger/besu

[benjamincburns]

Turns out that there are integration tests for the ethereum adapter - I just didn't see them, as they were in a different module. The PR in question didn't break things for HTTP RPC connections, but it did break things for websockets. With my changes in #829, were the same PR to be put through again, I'd expect CI to catch it.

As a result, I'm closing this.