Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivateTransactionReceipt declares new fields instead of inheriting them #1132

Closed
lyotam opened this issue Dec 25, 2019 · 0 comments
Closed
Labels
bug A bug in behaviour or functionality

Comments

@lyotam
Copy link
Contributor

lyotam commented Dec 25, 2019

PrivateTransactionReceipt declares new fields instead of inheriting them

PrivateTransactionReceipt declares again the following fields instead of inheriting them:
private final String contractAddress;
private final String from;
private final String to;
private final List logs;
private final String transactionHash;
private final String status;

This creates two copies of the same field for the superclass (TransactionReceipt) & subclass (PrivateTransactionReceipt), and creates various issues.

Steps To Reproduce

Calling privateTransactionReceipt.isStatusOk()

Expected behavior

Result should be evaluated by the actual receipt status

Actual behavior

Result will always be true because superclass's status is always null, even though subclass status is not.

Environment

Running Besu 1.31 Quickstart network.

@lyotam lyotam added the bug A bug in behaviour or functionality label Dec 25, 2019
@mohamedelshami mohamedelshami closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in behaviour or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants