Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact of removing totalDifficulty from block info #2106

Closed
makkanlover opened this issue Oct 9, 2024 · 2 comments
Closed

Impact of removing totalDifficulty from block info #2106

makkanlover opened this issue Oct 9, 2024 · 2 comments
Labels
needs-review issue/PR needs review from maintainer

Comments

@makkanlover
Copy link

makkanlover commented Oct 9, 2024

The go-ethereum release notes v1.14.11 suggest that totalDifficulty will be removed from the Block parameters.
ethereum/go-ethereum#30386

I apologize if I'm wrong, but I think that if this release is applied, block information may not be available through web3j.

Actual implementation
https://github.com/hyperledger/web3j/blob/86df48c8414513f6b3109ce8e783bd2c724a9fa4/core/src/main/java/org/web3j/protocol/core/methods/response/EthBlock.java#L329

I would like to know if the removal of totalDifficulty will have any impact, and if so, when the issue will be addressed.

@makkanlover makkanlover added the needs-review issue/PR needs review from maintainer label Oct 9, 2024
@makkanlover
Copy link
Author

I used this endpoint to check whether it would still work even if totalDifficulty was gone.
https://ethereum-sepolia-rpc.publicnode.com

As a result, it worked without any problems, so I will close this issue.

@1329576606
Copy link
Contributor

java.lang.RuntimeException: com.alibaba.fastjson.JSONException: write javaBean error, fastjson version 1.2.83, class org.web3j.protocol.core.methods.response.EthBlock$Block, method : getTotalDifficulty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review issue/PR needs review from maintainer
Projects
None yet
Development

No branches or pull requests

2 participants