Update get/set_did_public to use a storage record pointer #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 98.23% 98.21% -0.03%
==========================================
Files 466 466
Lines 26708 26739 +31
==========================================
+ Hits 26237 26261 +24
- Misses 471 478 +7 |
TimoGlastra
reviewed
Jun 17, 2021
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
fast-did-public
branch
from
0710ea7 to
ce6454a
Compare
swcurran
approved these changes
Jun 22, 2021
This was referenced Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be much faster when there are many DIDs stored in the wallet.
The 'public' DID metadata property is now generally ignored except when auto-upgrading an existing wallet. The
get_posted_didsmethod is updated to NOT filter the public DID, as it did previously.Includes a couple fixes for warnings when running tests.