OOB Protocol - CredentialOffer Attachment Support #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DaevMithran <[email protected]>
…ection, tests Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into oob_cred_offer
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into oob_cred_offer
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
| @@ -172,7 +181,9 @@ async def create_invitation( | |||
| a_id, | |||
| ) | |||
| message_attachments.append( | |||
| InvitationMessage.wrap_message(cred_ex_rec.cred_offer.offer()) | |||
| InvitationMessage.wrap_message( | |||
| cred_ex_rec.cred_offer.serialize() | |||
There was a problem hiding this comment.
I see here it's using cred_ex_rec.cred_offer but at line 175 it's using cred_ex_rec.credential_offer_dict, is that correct?
There was a problem hiding this comment.
cred_offer in V20CredExRecord is same as credential_offer_dict in V10CredentialExchange. I think this is correct.
Signed-off-by: Shaanjot Gill <[email protected]>
andrewwhitehead
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-offerendpoint inissue-credential-v1andissue-credential-v2to create an offer independent of connection.issue-credential-v1andissue-credential-v2credential offer workflow[Faber] with auto flags, offer_sent -> request_received -> credential_issued
[Alice] with auto flags, offer_received -> request_sent -> credential_received