Add "sent" key to both Schema and Cred Defs when using Endorsers #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When publishing a schema that has already been published, we should respond back with the schema ID, rather than return an error about how the `signed_txn` key does not exist on the schema_def object. Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
When publishing a credential definition that has already been published, we should respond back with the `cred_def_id`, rather than return an error about how the `signed_txn` key does not exist on the cred_def object. Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
The OpenAPI Spec schema indicates that "sent" is a possible field, however, no code paths (aside from the changes in the last two commits) returned it. Seeing as the last two commits return it during an error case, the changes here now return the same data during a successful case. This should make it easier for controllers to grab the `schema_id` or the `cred_def_id` under both circumstances. Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Add the `sent` key to the response for non-authors to follow the OpenAPI Schema Specification. Due to the fact that removing the old values would be a breaking change, I have left those values in for the time being to allow for a migration path to the new `sent` key. Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
ianco
approved these changes
Mar 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
- Coverage 95.50% 95.50% -0.01%
==========================================
Files 528 528
Lines 32734 32738 +4
==========================================
+ Hits 31264 31266 +2
- Misses 1470 1472 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an Author, if I attempt to publish duplicate schemas or credential definitions, I get a trace stack returned to me complaining about how the
signed_txnkey does not exist. While I adding a response for that situation (to just return the schema ID/ Cred Def ID instead of an error), I noticed that we were never populating the"sent"key in our responses to controllers. I have standardized the responses to follow the OpenAPI Schema and included the"sent"key.