Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update IndyLedgerRequestsExecutor logic - multitenancy and basic base wallet type #1700

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

shaangill025
Copy link
Contributor

  • resolve Multitenancy issue-credential send-request 500 error #1691
  • Earlier IndyLedgerRequestsExecutor instance was retrieved by calling profile.inject(IndyLedgerRequestsExecutor) which would correspond to the root_profile. If the base wallet_type is basic then the BaseLedger instance will not be specified which caused the above issue. I have now updated the logic to create a new IndyLedgerRequestsExecutor instance for each sub wallet.

Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swcurran swcurran merged commit 97192ec into openwallet-foundation:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multitenancy issue-credential send-request 500 error
3 participants