Fix handling of non-revocable credential when timestamp is specified (askar/credx)

[andrewwhitehead]

Test output with the error (mixing revocable and non-revocable credentials in one proof): #1761 (comment)

[codecov-commenter]

Codecov Report

Merging #1847 (be27d36) into main (47dbb28) will increase coverage by 0.00%.
The diff coverage is 76.47%.

@@           Coverage Diff           @@
##             main    #1847   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         536      536           
  Lines       34012    34015    +3     
=======================================
+ Hits        31878    31881    +3     
  Misses       2134     2134           

[swcurran]

Trying to figure out how to test this locally with Askar. Do we merge this and then test with the #1761 branch?

@shaangill025 -- can you review and (hopefully) approve? Or perhaps @ianco ?

Thanks!

[andrewwhitehead]

It can be tested with BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ./run_bdd -t @T003-RFC0454.1,@T003-RFC0454.2 or if you don't want to run the other services.. LEDGER_URL=http://test.bcovrin.vonx.io PUBLIC_TAILS_URL=https://tails-test.vonx.io BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ./run_bdd -t @T003-RFC0454.1,@T003-RFC0454.2

[swcurran]

Doh...you mean like @ianco said to do, and I did do, earlier today? :-) Thanks!