-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle connection invitations in base64 or URL formats #186
Handle connection invitations in base64 or URL formats #186
Conversation
Signed-off-by: Andrew Whitehead <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 71.75% 71.75%
=======================================
Files 218 218
Lines 9883 9883
=======================================
Hits 7092 7092
Misses 2791 2791 |
@andrewwhitehead - doesn't seem to work with the full URL. The connection process definitely starts, but I don't get a prompt in the Alice window - it just seems to hang as below:
|
Same behaviour if I just paste in the base64 encoded text:
On the agentbook side, it shows that it received the connection request, sent the connection response and then...nothing. Leaving Alice running, I eventually get this error:
|
@swcurran Is your Alice agent routable? |
@andrewwhitehead - don't know - I'm just using the "run_demo alice" on the ACA-Py side. I just know that what worked last week with Agentbook does not work now. Last week, I had to decode the URL to grab the JSON invite, but once I did that, everything worked. Now it hangs as noted above. |
FYI - same behaviour as last week (using the base64url decoded JSON data) fails as well - no connection established. This is the data I used: {"recipientKeys": ["3KwBC89e7WNhPMJDe3WvyTfrPgJZJt739pTm5hD2a8Tw"], "routingKeys": [], "serviceEndpoint": "https://agentbook.vonx.io:10000", "label": "AgentBook", "@id": "51779334-5df9-4307-b56b-7b61d98891d6", "@type": "did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/connections/1.0/invitation"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous notes were based on tests with a local agent, which (of course) is not going to work. Once I moved the test to Play-With-VON, all worked well.
Sorry about that.
Fixes #180