Fix ledger request signing issue; avoid duplicate public DID lookups

[andrewwhitehead]

• don't require a signature for get_txn_request in credential_definition_id2schema_id
• avoid repeated lookups of public DID when submitting ledger requests

[codecov-io]

Codecov Report

Merging #215 into master will decrease coverage by 0.01%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   72.68%   72.66%   -0.02%     
==========================================
  Files         219      219              
  Lines       10136    10147      +11     
==========================================
+ Hits         7367     7373       +6     
- Misses       2769     2774       +5

[swcurran]

Ran the faber demo and it failed on this branch and master with the following error:

Traceback (most recent call last):
  File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/indy/demo/runners/faber.py", line 293, in <module>
    asyncio.get_event_loop().run_until_complete(main(args.port, args.timing))
  File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/asyncio/base_events.py", line 484, in run_until_complete
    return future.result()
  File "/home/indy/demo/runners/faber.py", line 154, in main
    "degree schema", version, ["name", "date", "degree", "age"]
  File "/home/indy/demo/runners/support/agent.py", line 138, in register_schema_and_creddef
    "/credential-definitions", credential_definition_body
  File "/home/indy/demo/runners/support/agent.py", line 347, in admin_POST
    return await self.admin_request("POST", path, data, text, params)
  File "/home/indy/demo/runners/support/agent.py", line 332, in admin_request
    raise Exception(f"Unexpected HTTP response: {resp.status}")
Exception: Unexpected HTTP response: 500

Please investigate (I think you know what the issue is) and add the fix to this PR.

[swcurran]

Another error, this time in the Proof Request/Proof process. Ran the Alice/Faber demo through to the proof process and Alice's agent had this error:

Alice      | 2019-10-18 21:35:36,082 aiohttp.server ERROR Error handling request
Alice      | Traceback (most recent call last):
Alice      |   File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 418, in start
Alice      |     resp = await task
Alice      |   File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp/web_app.py", line 458, in _handle
Alice      |     resp = await handler(request)
Alice      |   File "/home/indy/aries_cloudagent/messaging/present_proof/v1_0/routes.py", line 361, in presentation_exchange_credentials_list
Alice      |     presentation_referents = request.match_info.get("referent").split(",")
Alice      | AttributeError: 'NoneType' object has no attribute 'split'
Presentation: state = request_received , presentation_exchange_id = 37245d6a-dbdf-4727-88b4-f58fcc905b1e

Please investigate. Include in this or should it be a separate issue?

[swcurran]

Working fine now. Review time.

[swcurran]

Looks good, demo runs...