Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nightly tests failing on Python 3.10 #2435

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Aug 18, 2023

Before the recent support for nightly release tests for Python 3.10 (see the logs here) were broken this fix corrected the tests by simply replacing async_case with the original unittest library.

A similar issue was resolved for the same incompatibility in #2187

As async_case was simply a backport of functionality included since Python 3.8 and acapy supports Python 3.9+ there is no longer a need for async_case.

Finally, this means we also restore the functionality of 2 additional tests that were previously skipped in #2187

Including Tests as a Dependency for Nightly Releases

In addition, the current release does not check that the tests for Python 3.10 were successful before building a nightly release. This PR also adds this as a dependency.

Additional context

The current source of the error with Python 3.10 is due to async_case using

            loop.run_until_complete(
                asyncio.gather(*to_cancel, loop=loop, return_exceptions=True))

as of Python 3.10 the loop keyword has been depreciated in asyncio.gather.

This leads to the following exception
image

@Gavinok Gavinok requested review from Jsyro and dbluhm August 18, 2023 21:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Gavinok Gavinok requested a review from swcurran August 18, 2023 21:13
@swcurran
Copy link
Contributor

Looks good to me, but I think it better that @dbluhm or @usingtechnology review, approve and merge this.

Thanks!

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swcurran swcurran merged commit 94680bf into openwallet-foundation:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants