Fix for nightly tests failing on Python 3.10 #2435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the recent support for nightly release tests for Python 3.10 (see the logs here) were broken this fix corrected the tests by simply replacing async_case with the original unittest library.
A similar issue was resolved for the same incompatibility in #2187
As async_case was simply a backport of functionality included since Python 3.8 and acapy supports Python 3.9+ there is no longer a need for async_case.
Finally, this means we also restore the functionality of 2 additional tests that were previously skipped in #2187
Including Tests as a Dependency for Nightly Releases
In addition, the current release does not check that the tests for Python 3.10 were successful before building a nightly release. This PR also adds this as a dependency.
Additional context
The current source of the error with Python 3.10 is due to async_case using
as of Python 3.10 the
loop
keyword has been depreciated in asyncio.gather.This leads to the following exception