Update demo/playground scripts #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Sherman <[email protected]>
remove old scripts. Signed-off-by: Jason Sherman <[email protected]>
Signed-off-by: Jason Sherman <[email protected]>
Signed-off-by: usingtechnology <[email protected]>
Signed-off-by: Jason Sherman <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
dbluhm
approved these changes
Oct 25, 2023
This was referenced Oct 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify (from the end user perspective) usage of the scripts leveraging the playground demo, I've docker-ized them; no more installing requirements (or python for that matter).
The scripts themselves are still simple, test that the playground agents are running, illustrate how to connect. When working on the mediator service, we added another script/test that would connect through the mediator service.
I picked up this "technique" from @dbluhm when adding in anoncreds-rs. It was a great way to prove it all worked and illustrated the intended flow/usage.
This allows us to get rid of a
requirements.txtand any PRs for dependabot on that file. Still have a poetry.lock, but those dependabot PRs seem to go smoother.Closes #2555