Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal and Goal Code in invitation URL. #2591

Conversation

usingtechnology
Copy link
Contributor

Add a unit test to ensure goal/goal code are in the encoded invitation URL.

Fixes #2583

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Contributor

swcurran commented Nov 2, 2023

Awesome — thanks. I was going to make the change myself, but the test — not that. Nice!

@swcurran swcurran merged commit 85475e1 into openwallet-foundation:main Nov 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating an out-of-band invitation does not include goal code in invitation_url encoding
2 participants