Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message transport refactoring #269

Merged
merged 31 commits into from
Nov 29, 2019
Merged

Message transport refactoring #269

merged 31 commits into from
Nov 29, 2019

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Nov 16, 2019 •
edited
Loading

  • move unpacking and return routing into inbound transport manager
  • move packing, delivery tracking and retries into outbound transport manager
  • apply a limiter on the number of concurrent message handlers (agent message handlers + admin API handlers)
  • add support for --max-message-size parameter

@codecov-io
Copy link

codecov-io commented Nov 16, 2019 •
edited
Loading

Codecov Report

Merging #269 into master will increase coverage by 0.73%.
The diff coverage is 87.11%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage    79.9%   80.63%   +0.73%     
==========================================
  Files         230      232       +2     
  Lines       10416    10769     +353     
==========================================
+ Hits         8323     8684     +361     
+ Misses       2093     2085       -8

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2019

This pull request introduces 1 alert when merging 3737906 into 77f47b7 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2019

This pull request introduces 1 alert when merging 422fe8b into 77f47b7 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@andrewwhitehead andrewwhitehead force-pushed the refactor/transport branch 5 times, most recently from b3f1b28 to 204af41 Compare November 21, 2019 22:56
@andrewwhitehead andrewwhitehead marked this pull request as ready for review November 22, 2019 18:43
@andrewwhitehead andrewwhitehead force-pushed the refactor/transport branch 2 times, most recently from 6d6c274 to 7877fd5 Compare November 26, 2019 18:06
@andrewwhitehead
initial refactoring
87daddc 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
more transport refactoring, now functional again
97edded 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
add new task queue class
3326655 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
move task queue to dispatcher
0d61d15 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
move functionality into inbound transport manager
f62649e 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
move functionality into outbound transport manager
8985fe5 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
task queue improvements and test fixes; clean up outbound message que…
1cb61ff 
…ue handling

Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
unit test fixes
39994b8 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
handle webhook dispatch via the outbound transport manager
a9d9d44 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
update message delivery references
78b1bd2 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
add task queue unit tests
fa96781 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
respond to webhook in demo immediately
4429104 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
adjust task limits
59a00d2 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
add tests to inbound session
84d273b 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
restore return routing and add associated tests
93d5460 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
fix variable reference
deda9c1 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
remove unused function
9cdd2e6 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
fix updated ping message handlers
76b7f9a 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
log message handler exceptions
5b5b3d0 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
adjust outbound HTTP limits
f589bb6 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
fix compatibility with aries toolbox
e12fdb9 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
fix check for --debug flag; more cleanups for return routing
64b13b5 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
extend unit tests
4bc4071 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
remove unused BaseRequestContext
45550a9 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
add conductor stats to /status endpoint; replace empty /modules endpo…
eaa2214 
…int with /plugins

Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
speed up admin websocket test
e079319 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
remove debug statement
3faf3a4 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
fix import from new unit tests
c2c55e6 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
fix occasional issue delivering the last message in a sequence
7dba582 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
add support for --max-message-size parameter (fixes openwallet-founda…
e3121b4 
…tion#267)

Signed-off-by: Andrew Whitehead <[email protected]>
swcurran
swcurran approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed by Wade and the code worked. May not have improved the performance, but the new structure is better.

Approved.

@swcurran swcurran merged commit b333150 into openwallet-foundation:master Nov 29, 2019
@andrewwhitehead andrewwhitehead deleted the refactor/transport branch February 29, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

@nrempel nrempel Awaiting requested review from nrempel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewwhitehead @codecov-io @swcurran