fix: print provision messages when auto-provision is triggered #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
approved these changes
Jul 2, 2024
It was recently discovered that if you set a static seed, and you have auto-provisioning enabled on the start command, there is no way to get the verkey for the created DID. The verkey is never printed out to the command line and I do not remember there being an API for retrieving the verkey (one of those, "See it once, copy it, or forever lose it" kinds of things). After this point in the code, the only thing that "provision" enables are the print statements talking about the did/verkey being created as well as some basic profile information. It doesn't trigger any code that would make changes to the system, those lines precede the line I've added. Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
TheTechmage
force-pushed
the
fix/provision
branch
from
b3fb780 to
988037e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently discovered that if you set a static seed, and you have auto-provisioning enabled on the start command, there is no way to get the verkey for the created DID. The verkey is never printed out to the command line and I do not remember there being an API for retrieving the verkey (one of those, "See it once, copy it, or forever lose it" kinds of things).
After this point in the code, the only thing that "provision" enables are the print statements talking about the did/verkey being created as well as some basic profile information. It doesn't trigger any code that would make changes to the system, those lines precede the line I've added.