🎨 organize imports #3169
Merged
🎨 organize imports #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
|
|
Been itching to contribute this for a while. I reflexively sort imports, and always have to withhold here cuz it changes too much 😄 |
darshilnb
pushed a commit
to Northern-Block/aries-cloudagent-python
that referenced
this pull request
Sep 5, 2024
* 🎨 organize imports with `isort` Signed-off-by: ff137 <[email protected]> * 🎨 organize imports with `ruff check --select I --fix .` Signed-off-by: ff137 <[email protected]> * 🎨 ruff format Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now's probably as good a time as any to organize imports for the codebase!
At present, the Ruff formatter doesn't sort imports (they say it is planned): https://docs.astral.sh/ruff/formatter/#sorting-imports
But, they allow to sort imports and format with:
This is mostly identical to
isort, butisortincludes some additional improvements in structure.So, I applied
isort . --profile black, followed byruff check --select I --fixandruff format.Tada. 🎉 One bulk change to neaten up imports across the board.
Thought this is maybe worth squeezing in before the official release. Can come later if it's just a spanner in the works.
I don't see any need to include a rule like this to the lint workflow. That can probably be added eventually when ruff supports organizing imports in one command.