Remove previous credential and presentation protocols #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 90.64% 93.84% +3.20%
==========================================
Files 249 229 -20
Lines 12529 11588 -941
==========================================
- Hits 11357 10875 -482
+ Misses 1172 713 -459 |
|
This pull request fixes 2 alerts when merging 2bcd606 into 592c431 - view on LGTM.com fixed alerts:
|
andrewwhitehead
force-pushed
the
remove-old-protocols
branch
from
2bcd606 to
35427b0
Compare
|
@andrewwhitehead - can you recommend reviewers for this? |
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
remove-old-protocols
branch
from
35427b0 to
50a731e
Compare
|
This pull request fixes 2 alerts when merging 50a731e into e8e7ee2 - view on LGTM.com fixed alerts:
|
|
Tests pass/demo runs, all looks good to me! And look at the test coverage! Approved. |
nrempel
approved these changes
Apr 15, 2020
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 90.64% 93.84% +3.20%
==========================================
Files 249 229 -20
Lines 12529 11588 -941
==========================================
- Hits 11357 10875 -482
+ Misses 1172 713 -459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change for 0.5.0