Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem report review #595

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Jul 9, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #595 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         247      248    +1     
  Lines       13173    13187   +14     
=======================================
+ Hits        12710    12724   +14     
  Misses        463      463           

@ianco
Copy link
Contributor

ianco commented Jul 9, 2020

When running the demo (run faber and alice; issue credential and ask for proof) I get the following error in "alice":

#26 Send the proof to X
Alice | 2020-07-09 15:14:32,529 aries_cloudagent.core.dispatcher ERROR Handler error: presentation_exchange_send_presentation
Alice | Traceback (most recent call last):
Alice | File "/home/indy/aries_cloudagent/protocols/present_proof/v1_0/routes.py", line 928, in presentation_exchange_send_presentation
Alice | comment=body.get("comment"),
Alice | File "/home/indy/aries_cloudagent/protocols/present_proof/v1_0/manager.py", line 271, in create_presentation
Alice | presentation_request = presentation_exchange_record.presentation_request
Alice | AttributeError: 'NoneType' object has no attribute 'presentation_request'
Alice | 2020-07-09 15:14:32,532 aiohttp.server ERROR Error handling request
Alice | Traceback (most recent call last):
Alice | File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 418, in start
Alice | resp = await task
Alice | File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp/web_app.py", line 458, in _handle
Alice | resp = await handler(request)
Alice | File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp/web_middlewares.py", line 119, in impl
Alice | return await handler(request)
Alice | File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp_apispec/middlewares.py", line 45, in validation_middleware
Alice | return await handler(request)
Alice | File "/home/indy/aries_cloudagent/admin/server.py", line 199, in apply_limiter
Alice | return await task
Alice | File "/home/indy/aries_cloudagent/protocols/present_proof/v1_0/routes.py", line 928, in presentation_exchange_send_presentation
Alice | comment=body.get("comment"),
Alice | File "/home/indy/aries_cloudagent/protocols/present_proof/v1_0/manager.py", line 271, in create_presentation
Alice | presentation_request = presentation_exchange_record.presentation_request
Alice | AttributeError: 'NoneType' object has no attribute 'presentation_request'

@sklump sklump requested a review from ianco July 9, 2020 15:26
@sklump
Copy link
Contributor Author

sklump commented Jul 9, 2020

OK, give me a bit

@sklump
Copy link
Contributor Author

sklump commented Jul 9, 2020

Ha ha! Found it. Sheesh.

@ianco ianco merged commit 6ed55e8 into openwallet-foundation:master Jul 9, 2020
nrempel pushed a commit to nrempel/aries-cloudagent-python that referenced this pull request Jul 21, 2020
…rt-review

Problem report review
Signed-off-by: Nicholas Rempel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants