Transform to and from 'did:key' style keys in oob messages #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 29, 2020 14:30
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
nrempel
commented
Jul 29, 2020
| @@ -57,3 +59,19 @@ def b58_to_bytes(val: str) -> bytes: | |||
| def bytes_to_b58(val: bytes) -> str: | |||
| """Convert a byte string to base 58.""" | |||
| return base58.b58encode(val).decode("ascii") | |||
|
|
|||
|
|
|||
| def naked_to_did_key(key: str) -> str: | |||
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 250 250
Lines 13389 13404 +15
=======================================
+ Hits 13215 13230 +15
Misses 174 174 |
sklump
suggested changes
Jul 30, 2020
added 2 commits
August 10, 2020 15:44
Signed-off-by: Nicholas Rempel <[email protected]>
|
Thanks @sklump, cleaned up those issues |
|
Note that there's samey code in attachment decorator: https://github.com/hyperledger/aries-cloudagent-python/blob/240366c9f1dd16c389dd55daec9a8ae4a49305d2/aries_cloudagent/messaging/decorators/attach_decorator.py#L209 I will wait for this PR to merge and then I think these conversions, plus something like |
sklump
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts to and from
did:keystyle keys to conform with https://github.com/hyperledger/aries-rfcs/tree/master/features/0360-use-did-key