wire up cred-ex deletion; delete calls take HTTP DELETE methods #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sklump <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=========================================
Coverage ? 98.98%
=========================================
Files ? 256
Lines ? 13986
Branches ? 0
=========================================
Hits ? 13844
Misses ? 142
Partials ? 0 |
Signed-off-by: sklump <[email protected]>
|
What's up with black? |
aries_cloudagent/holder/routes.py
Outdated
| @@ -255,7 +255,7 @@ async def register(app: web.Application): | |||
| credentials_attr_mime_types_get, | |||
| allow_head=False, | |||
| ), | |||
| web.post("/credential/{credential_id}/remove", credentials_remove), | |||
| web.delete("/credential/{credential_id}/remove", credentials_remove), | |||
There was a problem hiding this comment.
Shouldn't it just be web.delete("/credential/{credential_id}" ..?
There was a problem hiding this comment.
Hey, yeah! I will push a change first thing tomorrow.
…ent-python into record-deletion-review
Signed-off-by: sklump <[email protected]>
andrewwhitehead
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sklump [email protected]