Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propose RFC: 0036 issue credential #36

Merged
merged 2 commits into from
May 29, 2019
Merged

propose RFC: 0036 issue credential #36

merged 2 commits into from
May 29, 2019

Conversation

swcurran
Copy link
Contributor

…d some updates based on community feedback

  • broke HIPE PR into issue and present
  • changed to verb-noun style for protocol name and messages
  • added feedback from community about optional messages, including when used with other than Indy
  • added names of ~attach element
  • added "comment" element where missing on messages
  • removed references to the ack and reject messages in favouring of adopting those from the standard ack and problem-report messages.
  • removed references to Indy-specific fields when they are available in the attachment (cred-def, rev-reg)
  • text updates to clarify intention.

Signed-off-by: Stephen Curran [email protected]

@swcurran swcurran changed the title Move the Issue Credential part of the Exchange Credentials HIPE PR an… Move/cleanup the Issue Credential part of the Exchange Credentials HIPE PR May 29, 2019
@swcurran swcurran changed the title Move/cleanup the Issue Credential part of the Exchange Credentials HIPE PR Propose Issue Credential May 29, 2019
@swcurran swcurran changed the title Propose Issue Credential Propose RFC: Issue Credential May 29, 2019
@swcurran swcurran changed the title Propose RFC: Issue Credential propose RFC: 0036 Issue Credential May 29, 2019
@swcurran swcurran changed the title propose RFC: 0036 Issue Credential propose RFC: 0036 issue credential May 29, 2019
@swcurran swcurran mentioned this pull request May 29, 2019
Closed
kdenhartog
kdenhartog approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status is proposed. This looks good to me.

@kdenhartog kdenhartog merged commit e9df9bf into decentralized-identity:master May 29, 2019
This was referenced Aug 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdenhartog kdenhartog kdenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swcurran @kdenhartog